Skip to content

test_actors#

dataset#

Source code in tests/unit/apps/core/api/dataset/test_actors.py 
21
22
23
24
25
26
27
28
29
30
31
@pytest.fixture
def dataset(
    admin_client, dataset_a_json, access_type_reference_data, license_reference_data, data_catalog
):
    del dataset_a_json["language"]
    del dataset_a_json["field_of_science"]
    del dataset_a_json["theme"]
    dataset_a_json["state"] = "draft"
    res = admin_client.post("/v3/datasets", dataset_a_json, content_type="application/json")
    assert res.status_code == 201
    return res.data

patch_dataset#

Source code in tests/unit/apps/core/api/dataset/test_actors.py 
34
35
36
37
38
39
40
41
42
43
44
45
@pytest.fixture
def patch_dataset(admin_client, dataset):
    def _patch(data: dict, expected_status=200):
        resp = admin_client.patch(
            f"/v3/datasets/{dataset['id']}", data, content_type="application/json"
        )
        if resp.status_code != expected_status:
            print(resp.data)
        assert resp.status_code == expected_status
        return resp.data

    return _patch

another_dataset_with_actors#

Source code in tests/unit/apps/core/api/dataset/test_actors.py 
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
@pytest.fixture
def another_dataset_with_actors(
    admin_client, dataset_b_json, access_type_reference_data, license_reference_data, data_catalog
):
    del dataset_b_json["language"]
    del dataset_b_json["field_of_science"]
    del dataset_b_json["theme"]

    teppo_org = {"pref_label": {"en": "teppo org"}}
    matti_org = {"pref_label": {"en": "matti org"}}
    dataset_b_json["actors"] = [
        {"person": {"name": "teppo"}, "organization": teppo_org},
        {"person": {"name": "matti"}, "organization": matti_org},
    ]

    res = admin_client.post("/v3/datasets", dataset_b_json, content_type="application/json")
    assert res.status_code == 201
    return res.data

test_create_actor#

Source code in tests/unit/apps/core/api/dataset/test_actors.py 
68
69
70
71
72
73
74
75
76
77
def test_create_actor(patch_dataset):
    org = {"pref_label": {"en": "organization"}}
    data = patch_dataset(
        {"actors": [{"person": {"name": "teppo"}, "organization": org, "roles": ["creator"]}]}
    )
    assert data["actors"] == [
        matchers.DictContaining(
            {"person": matchers.DictContaining({"name": "teppo"}), "roles": ["creator"]}
        )
    ]

test_create_actors_with_multiple_roles_identical#

Source code in tests/unit/apps/core/api/dataset/test_actors.py 
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
def test_create_actors_with_multiple_roles_identical(patch_dataset):
    org = {"pref_label": {"en": "organization"}}
    data = patch_dataset(
        {
            "actors": [
                {"person": {"name": "teppo"}, "organization": org, "roles": ["creator"]},
                {"person": {"name": "teppo"}, "organization": org, "roles": ["publisher"]},
            ]
        }
    )
    assert data["actors"] == [
        matchers.DictContaining(
            {
                "person": matchers.DictContaining({"name": "teppo"}),
                "organization": matchers.DictContaining(org),
                "roles": ["creator", "publisher"],
            }
        )
    ]

test_create_actors_with_multiple_roles_different_person_name#

Source code in tests/unit/apps/core/api/dataset/test_actors.py 
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
def test_create_actors_with_multiple_roles_different_person_name(patch_dataset):
    org = {"organization": {"pref_label": {"en": "organization"}}}
    data = patch_dataset(
        {
            "actors": [
                {"person": {"name": "matti"}, **org, "roles": ["creator"]},
                {"person": {"name": "teppo"}, **org, "roles": ["publisher"]},
            ]
        }
    )
    assert_nested_subdict(
        [
            {
                "person": {"name": "matti"},
                "roles": ["creator"],
            },
            {
                "person": {"name": "teppo"},
                "roles": ["publisher"],
            },
        ],
        data["actors"],
    )
    assert data["actors"][0]["person"]["id"] != data["actors"][1]["person"]["id"]

test_create_actors_with_multiple_roles_same_id#

Source code in tests/unit/apps/core/api/dataset/test_actors.py 
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
def test_create_actors_with_multiple_roles_same_id(patch_dataset):
    org = {"organization": {"pref_label": {"en": "organization"}}}
    data = patch_dataset(
        {
            "actors": [
                {"id": "#a1", "person": {"name": "teppo"}, **org, "roles": ["creator"]},
                {"id": "#a1", "person": {"name": "teppo"}, **org, "roles": ["publisher"]},
            ]
        }
    )
    assert data["actors"] == [
        matchers.DictContaining(
            {
                "person": matchers.DictContaining({"name": "teppo"}),
                "organization": matchers.DictContaining(org["organization"]),
                "roles": ["creator", "publisher"],
            }
        )
    ]

test_create_actors_with_multiple_roles_different_id#

Source code in tests/unit/apps/core/api/dataset/test_actors.py 
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
def test_create_actors_with_multiple_roles_different_id(patch_dataset):
    org = {"organization": {"pref_label": {"en": "organization"}}}
    data = patch_dataset(
        {
            "actors": [
                {"id": "#a1", "person": {"name": "teppo"}, **org, "roles": ["creator"]},
                {"id": "#a2", "person": {"name": "teppo"}, **org, "roles": ["publisher"]},
            ]
        }
    )
    assert_nested_subdict(
        [
            {
                "person": matchers.DictContaining({"name": "teppo"}),
                "roles": ["creator"],
            },
            {
                "person": matchers.DictContaining({"name": "teppo"}),
                "roles": ["publisher"],
            },
        ],
        data["actors"],
    )

test_create_actors_with_multiple_roles_same_person_id#

Source code in tests/unit/apps/core/api/dataset/test_actors.py 
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
def test_create_actors_with_multiple_roles_same_person_id(patch_dataset):
    org = {"organization": {"pref_label": {"en": "organization"}}}
    data = patch_dataset(
        {
            "actors": [
                {"person": {"id": "#teppo", "name": "teppo"}, **org, "roles": ["creator"]},
                {"person": {"id": "#teppo", "name": "teppo"}, **org, "roles": ["publisher"]},
            ]
        }
    )
    assert data["actors"] == [
        matchers.DictContaining(
            {
                "person": matchers.DictContaining({"name": "teppo"}),
                "roles": ["creator", "publisher"],
            }
        )
    ]

test_create_actors_with_multiple_roles_different_person_id#

Source code in tests/unit/apps/core/api/dataset/test_actors.py 
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
def test_create_actors_with_multiple_roles_different_person_id(patch_dataset):
    org = {"organization": {"pref_label": {"en": "organization"}}}
    data = patch_dataset(
        {
            "actors": [
                {**org, "person": {"id": "#teppo", "name": "teppo"}, "roles": ["creator"]},
                {**org, "person": {"id": "#otherteppo", "name": "teppo"}, "roles": ["publisher"]},
            ]
        }
    )
    assert_nested_subdict(
        [
            {
                "person": {"name": "teppo"},
                "roles": ["creator"],
            },
            {
                "person": {"name": "teppo"},
                "roles": ["publisher"],
            },
        ],
        data["actors"],
    )
    assert data["actors"][0]["person"]["id"] != data["actors"][1]["person"]["id"]

test_create_actors_with_multiple_roles_same_org_id#

Source code in tests/unit/apps/core/api/dataset/test_actors.py 
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
def test_create_actors_with_multiple_roles_same_org_id(patch_dataset):
    org = {"pref_label": {"en": "organization"}}
    data = patch_dataset(
        {
            "actors": [
                {"organization": {**org, "id": "#org1"}, "roles": ["creator"]},
                {"organization": {**org, "id": "#org1"}, "roles": ["publisher"]},
            ]
        }
    )
    assert data["actors"] == [
        matchers.DictContaining(
            {
                "organization": matchers.DictContaining(org),
                "roles": ["creator", "publisher"],
            }
        )
    ]

test_create_actors_with_multiple_roles_different_org_id#

Source code in tests/unit/apps/core/api/dataset/test_actors.py 
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
def test_create_actors_with_multiple_roles_different_org_id(patch_dataset):
    org = {"pref_label": {"en": "organization"}}
    data = patch_dataset(
        {
            "actors": [
                {"organization": {**org, "id": "#org1"}, "roles": ["creator"]},
                {"organization": {**org, "id": "#org2"}, "roles": ["publisher"]},
            ]
        }
    )
    assert_nested_subdict(
        [
            {
                "organization": org,
                "roles": ["creator"],
            },
            {
                "organization": org,
                "roles": ["publisher"],
            },
        ],
        data["actors"],
    )
    assert data["actors"][0]["organization"]["id"] != data["actors"][1]["organization"]["id"]

test_create_actors_with_multiple_roles_different_org_name#

Source code in tests/unit/apps/core/api/dataset/test_actors.py 
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
def test_create_actors_with_multiple_roles_different_org_name(patch_dataset):
    org1 = {"pref_label": {"en": "organization 1"}}
    org2 = {"pref_label": {"en": "organization 2"}}
    data = patch_dataset(
        {
            "actors": [
                {"organization": {**org1}, "roles": ["creator"]},
                {"organization": {**org2}, "roles": ["publisher"]},
            ]
        }
    )
    assert_nested_subdict(
        [
            {
                "organization": org1,
                "roles": ["creator"],
            },
            {
                "organization": org2,
                "roles": ["publisher"],
            },
        ],
        data["actors"],
    )
    assert data["actors"][0]["organization"]["id"] != data["actors"][1]["organization"]["id"]

test_create_actors_with_multiple_roles_identical_multilevel_org#

Source code in tests/unit/apps/core/api/dataset/test_actors.py 
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
def test_create_actors_with_multiple_roles_identical_multilevel_org(patch_dataset):
    org = {
        "pref_label": {"en": "subsub"},
        "parent": {"pref_label": {"en": "sub"}, "parent": {"pref_label": {"en": "top"}}},
    }
    data = patch_dataset(
        {
            "actors": [
                {"organization": org, "roles": ["creator"]},
                {"organization": org, "roles": ["publisher"]},
            ]
        }
    )
    assert_nested_subdict(
        [
            {
                "organization": org,
                "roles": ["creator", "publisher"],
            },
        ],
        data["actors"],
    )

flatten#

Source code in tests/unit/apps/core/api/dataset/test_actors.py 
316
317
318
319
320
321
322
def flatten(org):
    orgs = []
    while org:
        next_org = org.pop("parent", None)
        orgs.append(org)
        org = next_org
    return list(orgs)

test_create_multilevel_org_repeated_name#

Check that orgs won't recurse infinitely.

Source code in tests/unit/apps/core/api/dataset/test_actors.py 
325
326
327
328
329
330
331
332
333
334
335
def test_create_multilevel_org_repeated_name(patch_dataset):
    """Check that orgs won't recurse infinitely."""
    baseorg = {
        "pref_label": {"en": "org"},
    }
    org = {**baseorg, "parent": {**baseorg, "parent": {**baseorg, "parent": {**baseorg}}}}
    data = patch_dataset({"actors": [{"organization": org}]})
    flat = flatten(data["actors"][0]["organization"])
    assert len(flat) == 4
    assert len({o["id"] for o in flat}) == 4  # all orgs have different id
    assert sum(1 for o in flat if o["pref_label"] == baseorg["pref_label"]) == 4

test_create_multiple_child_orgs#

Source code in tests/unit/apps/core/api/dataset/test_actors.py 
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
def test_create_multiple_child_orgs(patch_dataset):
    parent = {"pref_label": {"en": "parent"}}
    sub1 = {"pref_label": {"en": "sub1"}, "parent": {**parent}}
    sub2 = {"pref_label": {"en": "sub2"}, "parent": {**parent}}

    data = patch_dataset(
        {
            "actors": [
                {"organization": sub1},
                {"organization": sub2},
            ]
        }
    )
    assert_nested_subdict(sub1, data["actors"][0]["organization"])
    assert_nested_subdict(sub2, data["actors"][1]["organization"])
    data["actors"][0]["organization"] != data["actors"][1]["organization"]
    data["actors"][0]["organization"]["parent"] == data["actors"][1]["organization"]["parent"]

    parent_id = data["actors"][0]["organization"]["parent"]["id"]
    assert Organization.objects.get(id=parent_id).children.count() == 2

test_create_actors_with_multiple_roles_other_person_has_only_id#

Source code in tests/unit/apps/core/api/dataset/test_actors.py 
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
def test_create_actors_with_multiple_roles_other_person_has_only_id(patch_dataset):
    org = {"pref_label": {"en": "organization"}}
    data = patch_dataset(
        {
            "actors": [
                {"person": {"id": "#1", "name": "teppo"}, "organization": org},
                {"person": {"id": "#1"}, "organization": org, "roles": ["publisher"]},
            ]
        }
    )
    assert data["actors"] == [
        matchers.DictContaining(
            {
                "person": matchers.DictContaining({"name": "teppo"}),
                "organization": matchers.DictContaining(org),
                "roles": ["publisher"],
            }
        )
    ]

test_create_actors_with_multiple_roles_other_org_has_only_id#

Source code in tests/unit/apps/core/api/dataset/test_actors.py 
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
def test_create_actors_with_multiple_roles_other_org_has_only_id(patch_dataset):
    org = {"id": "#org", "pref_label": {"en": "organization"}}
    data = patch_dataset(
        {
            "actors": [
                {"organization": org},
                {"organization": {"id": "#org"}, "roles": ["publisher"]},
            ]
        }
    )
    assert_nested_subdict(
        [
            {
                "organization": {"pref_label": org["pref_label"]},
                "roles": ["publisher"],
            }
        ],
        data["actors"],
    )

existing_actors#

Source code in tests/unit/apps/core/api/dataset/test_actors.py 
402
403
404
405
406
407
408
409
410
411
412
413
414
@pytest.fixture
def existing_actors(patch_dataset):
    teppo_org = {"pref_label": {"en": "teppo org"}}
    matti_org = {"pref_label": {"en": "matti org"}}
    data = patch_dataset(
        {
            "actors": [
                {"person": {"name": "teppo"}, "organization": teppo_org},
                {"person": {"name": "matti"}, "organization": matti_org},
            ]
        }
    )
    return data["actors"]

test_update_existing_actor_roles#

Source code in tests/unit/apps/core/api/dataset/test_actors.py 
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
def test_update_existing_actor_roles(patch_dataset, existing_actors):
    data = patch_dataset(
        {
            "actors": [
                {"id": existing_actors[0]["id"], "roles": ["contributor"]},
            ]
        }
    )
    assert_nested_subdict(
        [
            {
                **existing_actors[0],
                "roles": ["contributor"],
            }
        ],
        data["actors"],
    )

test_update_actor_order#

Source code in tests/unit/apps/core/api/dataset/test_actors.py 
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
def test_update_actor_order(patch_dataset, existing_actors):
    leena_org = {"pref_label": {"en": "leena org"}}
    new_person = {"person": {"name": "leena"}, "organization": leena_org}
    data = patch_dataset(
        {
            "actors": [
                {"id": existing_actors[1]["id"]},
                new_person,
                {"id": existing_actors[0]["id"]},
                {"id": existing_actors[1]["id"]},  # should get merged with first actor
            ]
        }
    )
    assert_nested_subdict(
        [
            existing_actors[1],
            new_person,
            existing_actors[0],
        ],
        data["actors"],
    )

test_update_existing_organizations#

Source code in tests/unit/apps/core/api/dataset/test_actors.py 
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
def test_update_existing_organizations(patch_dataset, existing_actors):
    org1 = {**existing_actors[0]["organization"]}
    org1["email"] = "testi@example.com"
    data = patch_dataset(
        {
            "actors": [
                {"person": existing_actors[0]["person"], "organization": org1},
                {"person": existing_actors[1]["person"], "organization": {"id": org1["id"]}},
            ]
        }
    )
    assert_nested_subdict(
        [
            {"person": existing_actors[0]["person"], "organization": org1},
            {"person": existing_actors[1]["person"], "organization": org1},
        ],
        data["actors"],
    )

test_update_existing_persons#

Source code in tests/unit/apps/core/api/dataset/test_actors.py 
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
def test_update_existing_persons(patch_dataset, existing_actors):
    person1 = {**existing_actors[0]["person"]}
    person1["email"] = "testi@example.com"
    data = patch_dataset(
        {
            "actors": [
                {"person": person1, "organization": existing_actors[0]["organization"]},
                {
                    "person": existing_actors[1]["person"],
                    "organization": existing_actors[1]["organization"],
                },
            ]
        }
    )
    assert_nested_subdict(
        [
            {"person": person1, "organization": existing_actors[0]["organization"]},
            {
                "person": existing_actors[1]["person"],
                "organization": existing_actors[1]["organization"],
            },
        ],
        data["actors"],
    )

test_reuse_existing_organization_role#

Source code in tests/unit/apps/core/api/dataset/test_actors.py 
505
506
507
508
509
def test_reuse_existing_organization_role(patch_dataset):
    org = {"pref_label": {"en": "Organization"}}
    data = patch_dataset({"actors": [{"organization": org, "roles": ["creator"]}]})
    data = patch_dataset({"actors": [{"id": data["actors"][0]["id"]}]})
    assert data["actors"][0]["roles"] == ["creator"]

test_clear_existing_organization_role#

Source code in tests/unit/apps/core/api/dataset/test_actors.py 
512
513
514
515
516
def test_clear_existing_organization_role(patch_dataset):
    org = {"pref_label": {"en": "Organization"}}
    data = patch_dataset({"actors": [{"organization": org, "roles": ["creator"]}]})
    data = patch_dataset({"actors": [{"id": data["actors"][0]["id"], "roles": []}]})
    assert data["actors"][0]["roles"] == []

test_set_organization_role_null#

Source code in tests/unit/apps/core/api/dataset/test_actors.py 
519
520
521
522
def test_set_organization_role_null(patch_dataset):
    org = {"pref_label": {"en": "Organization"}}
    data = patch_dataset({"actors": [{"organization": org, "roles": None}]}, expected_status=400)
    assert data["actors"][0]["roles"] == ["This field may not be null."]

test_create_actor_with_refdata_org_by_url#

Source code in tests/unit/apps/core/api/dataset/test_actors.py 
525
526
527
528
def test_create_actor_with_refdata_org_by_url(patch_dataset, organization_reference_data):
    org = organization_reference_data[0]
    data = patch_dataset({"actors": [{"organization": {"url": org.url}}]})
    assert_nested_subdict({"organization": {"pref_label": org.pref_label}}, data["actors"][0])

test_create_actor_with_refdata_org_by_id#

Source code in tests/unit/apps/core/api/dataset/test_actors.py 
531
532
533
534
def test_create_actor_with_refdata_org_by_id(patch_dataset, organization_reference_data):
    org = organization_reference_data[0]
    data = patch_dataset({"actors": [{"organization": {"id": org.id}}]})
    assert_nested_subdict({"organization": {"pref_label": org.pref_label}}, data["actors"][0])

test_create_actor_with_refdata_org_by_id_and_url#

Source code in tests/unit/apps/core/api/dataset/test_actors.py 
537
538
539
540
def test_create_actor_with_refdata_org_by_id_and_url(patch_dataset, organization_reference_data):
    org = organization_reference_data[0]
    data = patch_dataset({"actors": [{"organization": {"id": org.id, "url": org.url}}]})
    assert_nested_subdict({"organization": {"pref_label": org.pref_label}}, data["actors"][0])

test_create_actor_with_invalid_refdata_org#

Source code in tests/unit/apps/core/api/dataset/test_actors.py 
543
544
545
546
547
548
549
550
551
def test_create_actor_with_invalid_refdata_org(patch_dataset, organization_reference_data):
    org = organization_reference_data[0]
    data = patch_dataset(
        {"actors": [{"organization": {"url": org.url + "höpö"}}]}, expected_status=400
    )
    assert (
        str(data["actors"][0]["organization"]["url"])
        == "Reference organization matching query does not exist."
    )

test_create_actor_with_invalid_refdata_org_ok_url_bad_id#

Source code in tests/unit/apps/core/api/dataset/test_actors.py 
554
555
556
557
558
559
560
561
562
563
564
565
566
def test_create_actor_with_invalid_refdata_org_ok_url_bad_id(
    patch_dataset, organization_reference_data
):
    bad_id = uuid.UUID(int=0)
    org = organization_reference_data[0]
    data = patch_dataset(
        {"actors": [{"organization": {"id": bad_id, "url": org.url + "höpö"}}]},
        expected_status=400,
    )
    assert (
        str(data["actors"][0]["organization"]["url"])
        == "Reference organization matching query does not exist."
    )

test_create_actor_with_refdata_org_parent#

Source code in tests/unit/apps/core/api/dataset/test_actors.py 
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
def test_create_actor_with_refdata_org_parent(patch_dataset, organization_reference_data):
    org = organization_reference_data[0]
    data = patch_dataset(
        {
            "actors": [
                {"organization": {"pref_label": {"en": "Sub-org"}, "parent": {"url": org.url}}}
            ]
        }
    )
    assert_nested_subdict(
        {
            "organization": {
                "pref_label": {"en": "Sub-org"},
                "parent": {"pref_label": org.pref_label},
            }
        },
        data["actors"][0],
    )

test_create_actor_with_refdata_org_ignore_parent#

'Reparenting' a reference organization should not be possible.

Source code in tests/unit/apps/core/api/dataset/test_actors.py 
589
590
591
592
593
594
595
596
597
598
599
600
def test_create_actor_with_refdata_org_ignore_parent(patch_dataset, organization_reference_data):
    """'Reparenting' a reference organization should not be possible."""
    org = organization_reference_data[0]
    data = patch_dataset(
        {
            "actors": [
                {"organization": {"url": org.url, "parent": {"pref_label": {"en": "Sub-org"}}}}
            ]
        }
    )
    assert data["actors"][0]["organization"]["pref_label"] == org.pref_label
    assert data["actors"][0]["organization"].get("parent") is None

test_actor_does_not_exist#

Source code in tests/unit/apps/core/api/dataset/test_actors.py 
603
604
605
606
def test_actor_does_not_exist(patch_dataset):
    actor_id = 1
    data = patch_dataset({"actors": [{"id": actor_id}]}, expected_status=400)
    assert "DatasetActor does not exist in dataset" in str(data["actors"][0]["id"])

test_person_does_not_exist#

Source code in tests/unit/apps/core/api/dataset/test_actors.py 
609
610
611
612
def test_person_does_not_exist(patch_dataset):
    person_id = 1
    data = patch_dataset({"actors": [{"person": {"id": person_id}}]}, expected_status=400)
    assert "Person does not exist in dataset" in str(data["actors"][0]["person"]["id"])

test_organization_does_not_exist#

Source code in tests/unit/apps/core/api/dataset/test_actors.py 
615
616
617
618
619
620
621
622
def test_organization_does_not_exist(patch_dataset):
    organization_id = uuid.UUID(int=0)
    data = patch_dataset(
        {"actors": [{"organization": {"id": organization_id}}]}, expected_status=400
    )
    assert "Organization is not reference data and does not exist in dataset" in str(
        data["actors"][0]["organization"]["id"]
    )

test_actor_from_another_dataset#

Source code in tests/unit/apps/core/api/dataset/test_actors.py 
625
626
627
628
def test_actor_from_another_dataset(patch_dataset, another_dataset_with_actors):
    actor_id = another_dataset_with_actors["actors"][0]["id"]
    data = patch_dataset({"actors": [{"id": actor_id}]}, expected_status=400)
    assert "DatasetActor does not exist in dataset" in str(data["actors"][0]["id"])

test_person_from_another_dataset#

Source code in tests/unit/apps/core/api/dataset/test_actors.py 
631
632
633
634
def test_person_from_another_dataset(patch_dataset, another_dataset_with_actors):
    person_id = another_dataset_with_actors["actors"][0]["person"]["id"]
    data = patch_dataset({"actors": [{"person": {"id": person_id}}]}, expected_status=400)
    assert "Person does not exist in dataset" in str(data["actors"][0]["person"]["id"])

test_organization_from_another_dataset#

Source code in tests/unit/apps/core/api/dataset/test_actors.py 
637
638
639
640
641
642
643
644
def test_organization_from_another_dataset(patch_dataset, another_dataset_with_actors):
    organization_id = another_dataset_with_actors["actors"][0]["organization"]["id"]
    data = patch_dataset(
        {"actors": [{"organization": {"id": organization_id}}]}, expected_status=400
    )
    assert "Organization is not reference data and does not exist in dataset" in str(
        data["actors"][0]["organization"]["id"]
    )

test_create_actor_conflicting_person#

Source code in tests/unit/apps/core/api/dataset/test_actors.py 
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
def test_create_actor_conflicting_person(patch_dataset):
    org = {"organization": {"pref_label": {"en": "organization"}}}
    data = patch_dataset(
        {
            "actors": [
                {"id": "#actor", "person": {"name": "matti"}, **org},
                {"id": "#actor", "person": {"name": "teppo"}, **org},
            ]
        },
        expected_status=400,
    )
    assert data["actors"] == [
        {},
        {
            "id": "Conflicting data for DatasetActor #actor",
            "person": "Value conflicts with another in request",
        },
    ]

test_create_actor_conflicting_org#

Source code in tests/unit/apps/core/api/dataset/test_actors.py 
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
def test_create_actor_conflicting_org(patch_dataset):
    data = patch_dataset(
        {
            "actors": [
                {"id": "#actor", "organization": {"pref_label": {"en": "org1"}}},
                {"id": "#actor", "organization": {"pref_label": {"en": "org2"}}},
            ]
        },
        expected_status=400,
    )
    assert data["actors"] == [
        {},
        {
            "id": "Conflicting data for DatasetActor #actor",
            "organization": "Value conflicts with another in request",
        },
    ]

test_create_actor_person_conflicting_name#

Source code in tests/unit/apps/core/api/dataset/test_actors.py 
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
def test_create_actor_person_conflicting_name(patch_dataset):
    org = {"organization": {"pref_label": {"en": "organization"}}}
    data = patch_dataset(
        {
            "actors": [
                {"person": {"id": "#matti", "name": "matti"}, **org},
                {"person": {"id": "#matti", "name": "teppo"}, **org},
            ]
        },
        expected_status=400,
    )
    assert data["actors"] == [
        {},
        {
            "person": {
                "id": "Conflicting data for Person #matti",
                "name": "Value conflicts with another in request",
            }
        },
    ]

test_create_actor_organization_conflicting_pref_label#

Source code in tests/unit/apps/core/api/dataset/test_actors.py 
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
def test_create_actor_organization_conflicting_pref_label(patch_dataset):
    data = patch_dataset(
        {
            "actors": [
                {"organization": {"id": "#org", "pref_label": {"en": "org1"}}},
                {"organization": {"id": "#org", "pref_label": {"en": "org2"}}},
            ]
        },
        expected_status=400,
    )
    assert data["actors"] == [
        {},
        {
            "organization": {
                "id": "Conflicting data for Organization #org",
                "pref_label": "Value conflicts with another in request",
            }
        },
    ]

test_existing_actor_conflicting_person#

Source code in tests/unit/apps/core/api/dataset/test_actors.py 
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
def test_existing_actor_conflicting_person(patch_dataset, existing_actors):
    org = {"organization": {"pref_label": {"en": "organization"}}}
    actor_id = existing_actors[0]["id"]
    data = patch_dataset(
        {
            "actors": [
                {"id": actor_id, "person": {"name": "matti"}, **org},
                {"id": actor_id, "person": {"name": "teppo"}, **org},
            ]
        },
        expected_status=400,
    )
    assert data["actors"] == [
        {},
        {
            "id": f"Conflicting data for DatasetActor {actor_id}",
            "person": "Value conflicts with another in request",
        },
    ]

test_create_empty_actor#

Source code in tests/unit/apps/core/api/dataset/test_actors.py 
750
751
752
753
754
755
def test_create_empty_actor(patch_dataset):
    data = patch_dataset(
        {"actors": [{}]},
        expected_status=400,
    )
    assert data["actors"][0] == {"organization": "This field is required"}

test_create_empty_person#

Source code in tests/unit/apps/core/api/dataset/test_actors.py 
758
759
760
761
762
763
764
def test_create_empty_person(patch_dataset):
    org = {"organization": {"pref_label": {"en": "organization"}}}
    data = patch_dataset(
        {"actors": [{"person": {}}]},
        expected_status=400,
    )
    assert data["actors"][0] == {"organization": "This field is required"}

test_create_empty_organization#

Source code in tests/unit/apps/core/api/dataset/test_actors.py 
767
768
769
770
771
772
def test_create_empty_organization(patch_dataset):
    data = patch_dataset(
        {"actors": [{"organization": {}}]},
        expected_status=400,
    )
    assert data["actors"][0]["organization"] == {"pref_label": "Field is required."}

test_create_actor_no_person_or_org#

Source code in tests/unit/apps/core/api/dataset/test_actors.py 
775
776
777
778
779
780
def test_create_actor_no_person_or_org(patch_dataset):
    data = patch_dataset(
        {"actors": [{"roles": ["creator"]}]},
        expected_status=400,
    )
    assert data["actors"][0] == {"organization": "This field is required"}

test_update_actor_no_person_or_org#

Source code in tests/unit/apps/core/api/dataset/test_actors.py 
783
784
785
786
787
788
789
def test_update_actor_no_person_or_org(patch_dataset, existing_actors):
    actor_id = existing_actors[0]["id"]
    data = patch_dataset(
        {"actors": [{"id": actor_id, "person": None, "organization": None}]},
        expected_status=400,
    )
    assert data["actors"][0] == {"organization": "This field is required"}

test_update_organization_no_pref_label#

Source code in tests/unit/apps/core/api/dataset/test_actors.py 
792
793
794
795
796
797
798
def test_update_organization_no_pref_label(patch_dataset, existing_actors):
    organization_id = existing_actors[0]["organization"]["id"]
    data = patch_dataset(
        {"actors": [{"organization": {"id": organization_id, "pref_label": None}}]},
        expected_status=400,
    )
    assert data["actors"][0]["organization"] == {"pref_label": ["This field may not be null."]}

test_update_organization_empty_pref_label#

Source code in tests/unit/apps/core/api/dataset/test_actors.py 
801
802
803
804
805
806
807
808
809
def test_update_organization_empty_pref_label(patch_dataset, existing_actors):
    organization_id = existing_actors[0]["organization"]["id"]
    data = patch_dataset(
        {"actors": [{"organization": {"id": organization_id, "pref_label": {}}}]},
        expected_status=400,
    )
    assert data["actors"][0]["organization"] == {
        "pref_label": ["This dictionary may not be empty."]
    }

test_update_person_no_name#

Source code in tests/unit/apps/core/api/dataset/test_actors.py 
812
813
814
815
816
817
818
def test_update_person_no_name(patch_dataset, existing_actors):
    person_id = existing_actors[0]["person"]["id"]
    data = patch_dataset(
        {"actors": [{"person": {"id": person_id, "name": None}}]},
        expected_status=400,
    )
    assert data["actors"][0]["person"] == {"name": ["This field may not be null."]}

test_update_person_empty_name#

Source code in tests/unit/apps/core/api/dataset/test_actors.py 
821
822
823
824
825
826
827
def test_update_person_empty_name(patch_dataset, existing_actors):
    person_id = existing_actors[0]["person"]["id"]
    data = patch_dataset(
        {"actors": [{"person": {"id": person_id, "name": ""}}]},
        expected_status=400,
    )
    assert data["actors"][0]["person"] == {"name": ["This field may not be blank."]}

test_create_provenance_actor#

Source code in tests/unit/apps/core/api/dataset/test_actors.py 
830
831
832
833
834
835
def test_create_provenance_actor(patch_dataset):
    actor = {"organization": {"pref_label": {"en": "organization"}}}
    data = patch_dataset(
        {"provenance": [{"description": {"en": "provenance"}, "is_associated_with": [actor]}]},
    )
    assert_nested_subdict(actor, data["provenance"][0]["is_associated_with"][0])

test_create_provenance_and_role_refdata_actor#

Source code in tests/unit/apps/core/api/dataset/test_actors.py 
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
def test_create_provenance_and_role_refdata_actor(patch_dataset, organization_reference_data):
    org = organization_reference_data[0]
    actor = {
        "organization": {
            "id": org.id,
            "pref_label": {"en": "blah blah"},  # should be ignored
        }
    }
    data = patch_dataset(
        {
            "actors": [actor],
            "provenance": [{"description": {"en": "provenance"}, "is_associated_with": [actor]}],
        }
    )
    assert_nested_subdict({"organization": {"pref_label": org.pref_label}}, data["actors"][0])

test_create_provenance_and_role_actor#

Source code in tests/unit/apps/core/api/dataset/test_actors.py 
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
def test_create_provenance_and_role_actor(patch_dataset):
    actor = {"organization": {"pref_label": {"en": "organization"}}}
    data = patch_dataset(
        {
            "actors": [{**actor, "roles": ["creator"]}],
            "provenance": [{"description": {"en": "provenance"}, "is_associated_with": [actor]}],
        },
    )
    assert_nested_subdict(
        {
            "actors": [{**actor, "roles": ["creator"]}],
            "provenance": [{"description": {"en": "provenance"}, "is_associated_with": [actor]}],
        },
        data,
    )

test_create_provenance_actor_by_id#

Source code in tests/unit/apps/core/api/dataset/test_actors.py 
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
def test_create_provenance_actor_by_id(patch_dataset):
    actor = {"organization": {"pref_label": {"en": "organization"}}}
    data = patch_dataset(
        {
            "actors": [{**actor, "id": "#actor", "roles": ["creator"]}],
            "provenance": [
                {"description": {"en": "provenance"}, "is_associated_with": [{"id": "#actor"}]}
            ],
        },
    )
    assert_nested_subdict(
        {
            "actors": [{**actor, "roles": ["creator"]}],
            "provenance": [{"description": {"en": "provenance"}, "is_associated_with": [actor]}],
        },
        data,
    )

test_create_provenance_actor_by_id_error#

Source code in tests/unit/apps/core/api/dataset/test_actors.py 
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
def test_create_provenance_actor_by_id_error(patch_dataset):
    org = {"organization": {"pref_label": {"en": "organization"}}}

    data = patch_dataset(
        {
            "actors": [{"id": "#actor", "person": {}, **org, "roles": ["creator"]}],
            "provenance": [
                {"description": {"en": "provenance"}, "is_associated_with": [{"id": "#actor"}]}
            ],
        },
        expected_status=400,
    )
    assert data["actors"][0] == {"person": {"name": "Field is required."}}
    assert data["provenance"][0]["is_associated_with"][0] == {
        "person": {"name": "Field is required."}
    }

test_create_actor_by_provenance_actor_id#

Source code in tests/unit/apps/core/api/dataset/test_actors.py 
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
def test_create_actor_by_provenance_actor_id(patch_dataset):
    actor = {"organization": {"pref_label": {"en": "organization"}}}
    data = patch_dataset(
        {
            "actors": [{"id": "#actor", "roles": ["creator"]}],
            "provenance": [
                {
                    "description": {"en": "provenance"},
                    "is_associated_with": [{**actor, "id": "#actor"}],
                }
            ],
        },
    )
    assert_nested_subdict(
        {
            "actors": [{**actor, "roles": ["creator"]}],
            "provenance": [{"description": {"en": "provenance"}, "is_associated_with": [actor]}],
        },
        data,
    )

test_create_provenance_actor_by_existing_actor_id#

Source code in tests/unit/apps/core/api/dataset/test_actors.py 
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
def test_create_provenance_actor_by_existing_actor_id(patch_dataset):
    actor = {
        "organization": {"pref_label": {"en": "Org"}},
        "person": {"name": "teppo"},
    }
    data = patch_dataset(
        {
            "actors": [
                {**actor, "roles": ["creator"]},
            ]
        }
    )
    actor_id = data["actors"][0]["id"]
    data = patch_dataset(
        {
            "provenance": [  # patch only provenance
                {
                    "description": {"en": "provenance"},
                    "is_associated_with": [{"id": actor_id}],
                }
            ],
        },
    )
    assert_nested_subdict(
        {
            "actors": [{**actor, "roles": ["creator"]}],
            "provenance": [{"description": {"en": "provenance"}, "is_associated_with": [actor]}],
        },
        data,
    )

test_create_actor_by_existing_provenance_actor_id#

Source code in tests/unit/apps/core/api/dataset/test_actors.py 
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
def test_create_actor_by_existing_provenance_actor_id(patch_dataset):
    actor = {
        "organization": {"pref_label": {"en": "Org"}},
        "person": {"name": "teppo"},
    }
    data = patch_dataset(
        {
            "provenance": [  # patch only provenance
                {
                    "description": {"en": "provenance"},
                    "is_associated_with": [actor],
                }
            ],
        },
    )
    actor_id = data["provenance"][0]["is_associated_with"][0]["id"]
    data = patch_dataset(
        {
            "actors": [
                {"id": actor_id, "roles": ["creator"]},
            ]
        }
    )
    assert_nested_subdict(
        {
            "actors": [{**actor, "roles": ["creator"]}],
            "provenance": [{"description": {"en": "provenance"}, "is_associated_with": [actor]}],
        },
        data,
    )

test_existing_provenance_person_and_org#

Source code in tests/unit/apps/core/api/dataset/test_actors.py 
 995
 996
 997
 998
 999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
def test_existing_provenance_person_and_org(patch_dataset):
    actor = {
        "organization": {"pref_label": {"en": "Org"}},
        "person": {"name": "teppo"},
    }
    data = patch_dataset(
        {
            "provenance": [  # patch only provenance
                {
                    "description": {"en": "provenance"},
                    "is_associated_with": [actor],
                }
            ],
        },
    )
    person_id = data["provenance"][0]["is_associated_with"][0]["person"]["id"]
    organization_id = data["provenance"][0]["is_associated_with"][0]["organization"]["id"]
    data = patch_dataset(
        {
            "actors": [
                {
                    "person": {"id": person_id},
                    "organization": {"id": organization_id},
                    "roles": ["creator"],
                },
            ]
        }
    )
    assert_nested_subdict(
        {
            "actors": [{**actor, "roles": ["creator"]}],
            "provenance": [{"description": {"en": "provenance"}, "is_associated_with": [actor]}],
        },
        data,
    )

test_create_same_actor_twice_no_id#

Source code in tests/unit/apps/core/api/dataset/test_actors.py 
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
def test_create_same_actor_twice_no_id(patch_dataset):
    person = {"name": "teppo", "email": "teppo@example.com"}
    org = {"pref_label": {"en": "test org"}, "email": "testorg@example.com"}
    data = patch_dataset(
        {
            "actors": [
                {"person": person, "organization": org, "roles": ["creator"]},
            ]
        }
    )
    actor_id = data["actors"][0]["id"]
    data = patch_dataset(
        {
            "actors": [  # role is allowed to change
                {"person": person, "organization": org, "roles": ["publisher"]},
            ]
        }
    )
    assert actor_id == data["actors"][0]["id"]

test_create_same_person_twice_no_id#

Source code in tests/unit/apps/core/api/dataset/test_actors.py 
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
def test_create_same_person_twice_no_id(patch_dataset):
    person = {"name": "teppo", "email": "teppo@example.com"}
    org = {"pref_label": {"en": "test org"}, "email": "testorg@example.com"}
    data = patch_dataset(
        {
            "id": "#a",  # force new actor
            "actors": [
                {"person": person, "organization": org, "roles": ["creator"]},
            ],
        }
    )
    person_id = data["actors"][0]["person"]["id"]
    data = patch_dataset(
        {
            "id": "#a",  # force new actor
            "actors": [  # role is allowed to change
                {"person": person, "organization": org, "roles": ["publisher"]},
            ],
        }
    )
    assert person_id == data["actors"][0]["person"]["id"]

test_create_same_organization_twice_no_id#

Source code in tests/unit/apps/core/api/dataset/test_actors.py 
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
def test_create_same_organization_twice_no_id(patch_dataset):
    person = {"name": "teppo", "email": "teppo@example.com"}
    org = {"pref_label": {"en": "test org"}, "email": "testorg@example.com"}
    data = patch_dataset(
        {
            "id": "#a",  # force new actor
            "actors": [
                {"person": person, "organization": org, "roles": ["creator"]},
            ],
        }
    )
    organization_id = data["actors"][0]["organization"]["id"]
    data = patch_dataset(
        {
            "id": "#a",  # force new actor
            "actors": [  # role is allowed to change
                {"person": person, "organization": org, "roles": ["publisher"]},
            ],
        }
    )
    assert organization_id == data["actors"][0]["organization"]["id"]

test_create_actor_email_private#

Actor email addresses should not be visible to users without editing rights to dataset.

Source code in tests/unit/apps/core/api/dataset/test_actors.py 
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
def test_create_actor_email_private(patch_dataset, admin_client):
    """Actor email addresses should not be visible to users without editing rights to dataset."""
    data = patch_dataset(
        {
            "actors": [
                {
                    "person": {"name": "teppo", "email": "person@example.com"},
                    "organization": {"pref_label": {"en": "org"}, "email": "org@example.com"},
                    "roles": ["creator", "publisher"],
                }
            ]
        }
    )
    # Email should be visible when creating
    assert data["actors"][0]["person"]["email"] == "person@example.com"
    assert data["actors"][0]["organization"]["email"] == "org@example.com"

    res = admin_client.post(f"/v3/datasets/{data['id']}/publish", content_type="application/json")
    assert res.status_code == 200

    # Email should be visible on get if user has rights
    res = admin_client.get(f"/v3/datasets/{data['id']}", content_type="application/json")
    assert "email" in res.data["actors"][0]["person"]
    assert "email" in res.data["actors"][0]["organization"]

    # Email should not be visible for anonymous user
    anon_client = Client()
    res = anon_client.get(f"/v3/datasets/{data['id']}", content_type="application/json")
    assert "email" not in res.data["actors"][0]["person"]
    assert "email" not in res.data["actors"][0]["organization"]